Move query history files to new folders#2002
Merged
norascheuch merged 1 commit intomainfrom Jan 25, 2023
Merged
Conversation
Contributor
Author
|
The failing test is a failed CodeQL check in a file where I had do adjust an import. I suggest to create an issue to check this separately. |
koesie10
approved these changes
Jan 25, 2023
| queryServerLogger, | ||
| } from "./common"; | ||
| import { QueryHistoryManager } from "./query-history"; | ||
| import { QueryHistoryManager } from "./query-history/query-history"; |
Member
There was a problem hiding this comment.
This might be a good candidate for creating an index.ts file in the query-history directory so we can just import from ./query-history instead of ./query-history/query-history, but that's something better done in a follow-up PR if we want to do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
ready-for-doc-reviewlabel there.